Re: [PATCH 3/2] format-patch: use clear_commit_marks() instead of some adhocery

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 26, 2006, 22:44 UTC
Message-ID: <Pine.LNX.4.63.0606270042420.29667@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vhd27j3v8.fsf@assigned-by-dhcp.cox.net>

Hi,

On Mon, 26 Jun 2006, Junio C Hamano wrote:

Show 11 quoted lines

> diff --git a/commit.c b/commit.c
> index 946615d..69fbc41 100644
> --- a/commit.c
> +++ b/commit.c
> @@ -397,8 +397,7 @@ void clear_commit_marks(struct commit *c
>  	commit->object.flags &= ~mark;
>  	while (parents) {
>  		struct commit *parent = parents->item;
> -		if (parent && parent->object.parsed &&
> -		    (parent->object.flags & mark))
> +		if (parent && (parent->object.flags & mark))

This is probably not necessary for existing users, but it's a good change for the future: new users might be surprised to learn that there are unparsed objects, which still want to be handled.

Ciao, Dscho