Is anybody actually using git-cherry.sh?

Hi,

from git-cherry.sh:

-- snip --
for c in $inup
do
        git-diff-tree -p $c
done | git-patch-id |
while read id name
do
        echo $name >>$patch/$id
done
-- snap --

AFAICS this _must_ be broken. git-diff-tree -p <ent> does not emit "diff-tree <sha1>", and neither "commit <sha1>" lines. So this code would yield just one file, treating all diffs as one huge diff. A quick fix would be this change (without the patch I sent out earlier):

+	echo "diff-tree $c"
 	git-diff-tree -p $c

Am I wrong?

Ciao, Dscho