Re: git-format-patch builtin isn't using git-cherry?

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jun 23, 2006, 12:05 UTC
Message-ID: <Pine.LNX.4.63.0606231357420.29667@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <46a038f90606221732k6d93bcceic2761081d7a7c72b@mail.gmail.com>

Hi,

On Fri, 23 Jun 2006, Martin Langhoff wrote:

> Reading cmd_format_patch() in builtin-log.c, it seems to have lost that 
> magic that made it so useful... :( Can a kind soul that speaks C 
> fluently help me out here?

My fault. But note that it is much faster now, too! I think I can trick it back into doing something like the old script, but I'll do that only with an option (in order to not slow down the now-common case). And it will take a while. So if anybody wants to give it a try...

Basically, it will involve the following recipe:

	- add a DIFF_FORMAT_PATCH_ID
	- calculate _all_ the patch ids in upstream since branch point
	- in cmd_format_patch, in the get_revision() loop, skip those
	  commits which have the same patch id

Ciao, Dscho