Re: [PATCH] git-receive-pack needs to set umask(2)

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: May 29, 2006, 07:13 UTC
Message-ID: <Pine.LNX.4.63.0605290910210.8863@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <e5d6i0$rnf$1@sea.gmane.org>

Hi,

On Mon, 29 May 2006, Jakub Narebski wrote:

Show 9 quoted lines

> Michael Richardson wrote:
> 
> > This change adds $GIT_DIR/umask to contain a single line, an integer
> > which will be fed to umask(). This should also work for the git daemon,
> > which I personally do not use, so this may be inappropriate.
> 
> Shouldn't it be done rather via $GIT_DIR/config file, and 
> git-repo-config? I.e. instead of adding new file to repository layout,
> $GIT_DIR/umask, add core.umask to git configuration?

See also

http://thread.gmane.org/gmane.comp.version-control.git/13856/focus=13876

The essence of the thread: If you want to do anything useful in a non-bare repository, you are likely using other tools than git, which do not interpret core.umask or $GIT_DIR/umask.

If you use a bare repository, just make it shared. No need for an umask.

Hth, Dscho