Re: Implementing branch attributes in git config

> Pavel Roskin <proski@gnu.org> writes:
> 
> > In particular, git-repo-config leaves the config file locked in the
> > regex is wrong:
> >
> > $ git-repo-config branch.fetch "master:origin" +
> > Invalid pattern: +
> > $ git-repo-config branch.fetch "master:origin" +
> > could not lock config file
> >
> > To fix it, just add "close(fd); unlink(lock_file);" after "Invalid
> > pattern" in config.c.
> 
> I'd give Johannes the first refusal right to deal with this and
> not touch repo-config.c myself for now, since I suspect I
> tempted him enough to restructure it ;-).

> > I don't quite understand what pattern is needed to add an entry.  "foo"
> > seems to work fine, I don't know why.
> 
> I think the value regexp is "replace the ones that match this",
> and the convention he came up with is to use "^$" to append (see
> some examples in t/t1300-repo-config.sh).
> 
> In any case, Documentation/git-repo-config.txt mentions
> value_regex without explaining what the semantics is.  This
> needs to be fixed, probably like the attached patch.
> 
> > That problem with multiple values is that they are quite fragile and
> > require special options to access them.  Since regex is used, dots in
> > the branch names need to be escaped.  Probably more escapes are needed.
> 
> I have a suspicion that using regex while is more powerful and
> expressive might be a mistake and it would be easier for users
> (both Porcelain and end-users) to use fnmatch() patterns.

> @@ -23,10 +23,11 @@ You can query/set/replace/unset options 
>  actually the section and the key separated by a dot, and the value will be
>  escaped.
>  
> -If you want to set/unset an option which can occur on multiple lines, you
> -should provide a POSIX regex for the value. If you want to handle the lines
> -*not* matching the regex, just prepend a single exclamation mark in front
> -(see EXAMPLES).
> +If you want to set/unset an option which can occur on multiple
> +lines, a POSIX regexp `value_regex` needs to be given.  Only the
> +existing values that match the regexp are updated or unset.  If
> +you want to handle the lines that do *not* match the regex, just
> +prepend a single exclamation mark in front (see EXAMPLES).