git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: Do not use zlib 1.1.3 with git packs!

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Apr 29, 2006, 01:47 UTC
Message-ID
<Pine.LNX.4.63.0604290341380.22696@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To
<Pine.LNX.4.63.0604290245510.30565@wbgn013.biozentrum.uni-wuerzburg.de>
Hi,
On Sat, 29 Apr 2006, Johannes Schindelin wrote:
> Upgrading to zlib 1.2.3 helped.
Apparently I was too enthusiastic to have a working system again.
The problem showed again, but with a different repository.
This time, though, I have an idea what could be the culprit.

In create_delta(), there might be illegal accesses. The function adler32() is called for BLK_SIZE bytes (which is 16 bytes at the moment), starting from data, which is initially trg_buf, and is incremented until it is (trg_buf + trg_size).

I gather that close to the end, adler32() tries to read 15 bytes after the end of the allocated target buffer.

Am I wrong?

Ciao, Dscho

Previous: Johannes SchindelinNext: Nicolas Pitre
Message 2 of 4 in “Do not use zlib 1.1.3 with git packs!”
  1. Johannes SchindelinApr 29, 2006
  2. Johannes SchindelinApr 29, 2006
  3. Nicolas PitreApr 29, 2006
  4. Junio C HamanoApr 29, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.