Re: Removal of "--merge-order"?

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 24, 2006, 21:37 UTC
Message-ID: <Pine.LNX.4.63.0602242230210.11479@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <Pine.LNX.4.64.0602240957430.22647@g5.osdl.org>

Hi,

On Fri, 24 Feb 2006, Linus Torvalds wrote:

> Now, rev-list.c is not the biggest file (apply.c is about twice the size), 
> but in many ways it's the most complex one by far. It's also the most 
> performance-critical one, and the one that it would be really nice if we 
> were to be able to libify it.

This is what I wanted to try today, but unfortunately I had to do real work :-(

> For example, instead of the horrid scriping language, I _think_ I could 
> almost libify it by just hooking into "show_commit", and using a callback 
> function for that (and then the stand-alone program would just make the 
> callback function be one that prints out the commit).

I don't find the scripting language you invented particularly horrid. Maybe some odd things (like "if" branching to the "else" block whenever *any* argument was passed), but not horrid.

But in the end I would prefer a libified git, if only to get rid of double parsing (if you pipe the output of git-rev-list to another git program, chances are that you parse the commit objects at least twice).

> That would possibly be a simpler way to get away from using nonportable 
> scripts. Plain C really does remain one of the most portable things out 
> there.

Yes.

Ciao, Dscho