Re: [PATCH] config.c: remove unnecessary header in minimum configuration file.

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Dec 5, 2005, 21:05 UTC
Message-ID: <Pine.LNX.4.63.0512052202300.12016@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vek4rb6vc.fsf@assigned-by-dhcp.cox.net>

Hi,

On Mon, 5 Dec 2005, Junio C Hamano wrote:

Show 7 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > However, you should also remove the header which is generated in init-db.c 
> > when it is determined that the file system does not respect the executable 
> > flag.
> 
> I suspect that code is not there anymore.

Oops. I missed that one (probably because it did not say anything about the filemode test in the shortlog).

However, reading the code I am not satisfied. If there is no template for the config file, it does not test the filemode at all.

In fact, it reverses my design: I did *not* touch an existing config file, but only created one if none existed. And if the filemode was not set, I threw the config file away.

Ciao, Dscho