Re: [PATCH] Add .git/version

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 17, 2005, 23:41 UTC
Message-ID: <Pine.LNX.4.63.0511180039270.18775@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <Pine.LNX.4.64.0511171131260.13959@g5.osdl.org>

Hi,

On Thu, 17 Nov 2005, Linus Torvalds wrote:

Show 15 quoted lines

> On Thu, 17 Nov 2005, Junio C Hamano wrote:
> > 
> >  - We want repository-format-version but that may be too
> >    long. Just saying version is a bit confusing.  Abbreviating
> >    it to repository-version makes it sound as if somebody took a
> >    snapshot (i.e. tar-tree $commit).  Whatever name we choose,
> >    let's pick a one not so confusing.
> 
> My one argument against this is that I don't see why we have to have a 
> separate file for this.
> 
> Why not just add a "core.version" flag to the config file? If no version 
> exists, assume it's version 1. And then, if we ever start using some other 
> version, make git-init-db always create the config file (the way we 
> already do for "core.filemode")

Note that git-sh-setup and setup_git_directory() should check for it and complain if it finds a value > 1. Else there is not much which prevents old tools (like current) to access future versions.

The actual number may come later. The check can't.

Ciao, Dscho