Re: [PATCH] Add option USE_INPLACE to Makefile

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Nov 16, 2005, 08:10 UTC
Message-ID: <Pine.LNX.4.63.0511160903360.16063@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <7vmzk5cmnd.fsf@assigned-by-dhcp.cox.net>

Hi,

On Tue, 15 Nov 2005, Junio C Hamano wrote:

Show 8 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> > and you no longer need to worry about setting variables like
> > GIT_EXEC_PATH and GIT_PYTHON_PATH.
> 
> I think you can already do this in the config.mak mechanism
> added by, ... (goes and asks git-whatchanged about it),...
> *you*, no?

Yes.

But I imagined a programmer new to git. And then I looked at the situation I had yesterday after pulling to 97fc6c5f.. in which I was able to build just fine, but calls like "git diff" no longer worked.

Now, *I* know what I have to put into config.mak, but I would hate the project if I was new to it, tried to play around with it, and nothing would work in spite of being compiled with just one warning, thank you.

> You know you are not installing things anyway if you do that, so
> I do not see much point hiding the install target and friends
> either.

Just a safety measure for the price of two lines. When I check out a new project, I do "make", play around with it, and then do "make install". If I had to set "export USE_INPLACE=1", "make install" should barf, because the compiled programs are not meant to be used anywhere else.

Having said that, I probably should have called it an RFC, not a PATCH. Sorry.

Ciao, Dscho