git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] make t5501 less annoying, was Re: [PATCH 4/8] Implement an interoperability test for fetch-pack/upload-pack

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Oct 28, 2005, 03:59 UTC
Message-ID
<Pine.LNX.4.63.0510280557071.5054@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To
<Pine.LNX.4.63.0510280447440.20516@wbgn013.biozentrum.uni-wuerzburg.de>

On Linux, "mktemp tmp-XXXX" will not work. Also, redirect stderr on which, so it does not complain too loudly. After all, this test should only be executed when old binaries are available.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
---
 t/t5501-old-fetch-and-upload.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

applies-to: f961b5204f8ead99f2beb0b2dc9f1e662c47fd74 4462bf60f4fca1d7774f441b374943109083efd9

diff --git a/t/t5501-old-fetch-and-upload.sh b/t/t5501-old-fetch-and-upload.sh
index 86df785..ada5130 100755
--- a/t/t5501-old-fetch-and-upload.sh
+++ b/t/t5501-old-fetch-and-upload.sh
@@ -8,7 +8,7 @@
 
 cd $(dirname $0) || exit 1
 
-tmp=$(mktemp tmp-XXXX)
+tmp=$(mktemp /tmp/tmp-XXXXXXXX)
 
 retval=0
 
@@ -25,7 +25,7 @@ for i in $list; do
 	both) pgm="old-git-upload-pack"; replace="old-git-fetch-pack --exec=$pgm";;
 	esac
 
-	if which $pgm; then
+	if which $pgm 2>/dev/null; then
 		echo "Testing with $pgm"
 		sed -e "s/git-fetch-pack/$replace/g" \
 			-e "s/# old fails/warn/" < t5500-fetch-pack.sh > $tmp
---
0.99.8.GIT
Previous: Johannes Schindelin
Message 2 of 2 in “Implement an interoperability test for fetch-pack/upload-pack”
  1. 4/8 Implement an interoperability test for fetch-pack/upload-packJohannes Schindelin, Oct 28, 2005
  2. make t5501 less annoying, was Re: [PATCH 4/8] Implement an interoperability test for fetch-pack/upload-packJohannes Schindelin, Oct 28, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.