git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: git 565ebbf79f61873042c22a7126d002c104e056f4 broken on OpenBSD

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Oct 26, 2005, 17:03 UTC
Message-ID
<Pine.LNX.4.63.0510261901140.9686@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To
<20051026165515.GA16616@delft.aura.cs.cmu.edu>
Hi,
On Wed, 26 Oct 2005, Jan Harkes wrote:
> -		if (ret == EXDEV && !rename(tmpfile, filename))
> +		if (ret && ret != EEXIST && !rename(tmpfile, filename))

We don't need to test for ret, as we're already in a "if (ret)" block. What would happen if ret==EEXIST, and we try to rename() nevertheless? It should fail, too, right?

Ciao, Dscho

Previous: Jan HarkesNext: Linus Torvalds
Message 10 of 17 in “git 565ebbf79f61873042c22a7126d002c104e056f4 broken on OpenBSD”
  1. Randal L. SchwartzOct 26, 2005
  2. Randal L. SchwartzOct 26, 2005
  3. Johannes SchindelinOct 26, 2005
  4. Randal L. SchwartzOct 26, 2005
  5. Johannes SchindelinOct 26, 2005
  6. Randal L. SchwartzOct 26, 2005
  7. Jan HarkesOct 26, 2005
  8. Johannes SchindelinOct 26, 2005
  9. Jan HarkesOct 26, 2005
  10. Johannes SchindelinOct 26, 2005
  11. Linus TorvaldsOct 26, 2005
  12. Linus TorvaldsOct 26, 2005
  13. Johannes SchindelinOct 26, 2005
  14. Horst von BrandOct 26, 2005
  15. Randal L. SchwartzOct 26, 2005
  16. Junio C HamanoOct 26, 2005
  17. Randal L. SchwartzOct 26, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.