Re: [PATCH 4/4] git-fetch-pack: Implement client part of the multi_ack extension

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Oct 25, 2005, 21:02 UTC
Message-ID: <Pine.LNX.4.63.0510252300290.15756@wbgn013.biozentrum.uni-wuerzburg.de>
In-Reply-To: <20051025204754.GA8030@steel.home>

Hi,

On Tue, 25 Oct 2005, Alex Riesen wrote:

Show 22 quoted lines

> Johannes Schindelin, Sun, Oct 23, 2005 03:40:13 +0200:
> > This patch concludes the series, which makes 
> > git-fetch-pack/git-upload-pack negotiate a potentially better set of 
> > common revs. It should make a difference when fetching from a repository 
> > with a few branches.
> 
> This broke git-pull for me (the local one):
> 
>     /d/e/f.git$ git-pull
>     fatal: bad pack file
>     fatal: git-unpack-objects died with error code 128
>     Fetch failure: /a/b/c/.git
> 
> > applies-to: 6b4b7d9acf60aa99d961b599f37d0c824be79e27
> > 9adb6b3971e7daa79221d7dbe05b66327b266b86
> ...
> > diff --git a/fetch-pack.c b/fetch-pack.c
> > index 3a903c4..57602b9 100644
> > --- a/fetch-pack.c
> > +++ b/fetch-pack.c
> 
> Reverting just fetch-pack.c part of the patch helps.

Could you please try the patch I sent with the subject "[PATCH] fetch/upload: Fix corner case with few revs"? Your output looks exactly like what I fixed with that patch.

Ciao, Dscho