git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/8] fetch.c optimizations

From
Daniel Barkalow <barkalow@iabervon.org>
Date
Sep 21, 2005, 21:03 UTC
Message-ID
<Pine.LNX.4.63.0509211700161.23242@iabervon.org>
In-Reply-To
<20050921161829.GA20944@master.mivlgu.local>
On Wed, 21 Sep 2005, Sergey Vlasov wrote:
Show 8 quoted lines
> Hello!
> 
> I have noticed that git-*-fetch now uses much more CPU than it was
> before the modifications to fix recovery after interrupted fetch.
> Here is a series of small patches which fix the problems which I have
> found (some of the fixes give pretty impressive results, like a 14x
> decrease of CPU time); as a positive side effect, fetch.c becomes
> slightly smaller and hopefully simpler than before.

These all look like good changes. It would also be worth doing some optimization in the library, like making parse_object just return the object if we already have it.

	-Daniel
*This .sig left intentionally blank*
Previous: Sergey Vlasov
Message 12 of 12 in “fetch.c optimizations”
  1. 0/8 fetch.c optimizationsSergey Vlasov, Sep 21, 2005
  2. 1/8 fetch.c: Remove useless lookup_object_type() call in process()Sergey Vlasov, Sep 21, 2005
  3. Junio C HamanoSep 21, 2005
  4. Sergey VlasovSep 22, 2005
  5. 2/8 fetch.c: Make process() look at each object only onceSergey Vlasov, Sep 21, 2005
  6. 3/8 fetch.c: Remove redundant SCANNED flagSergey Vlasov, Sep 21, 2005
  7. 4/8 fetch.c: Remove redundant TO_FETCH flagSergey Vlasov, Sep 21, 2005
  8. 5/8 fetch.c: Remove some duplicated code in process()Sergey Vlasov, Sep 21, 2005
  9. 6/8 fetch.c: Remove redundant test of TO_SCAN in process()Sergey Vlasov, Sep 21, 2005
  10. 7/8 fetch.c: Clean up object flag definitionsSergey Vlasov, Sep 21, 2005
  11. 8/8 fetch.c: Remove call to parse_object() from process()Sergey Vlasov, Sep 21, 2005
  12. Daniel BarkalowSep 21, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.