Re: [PATCH/RFC] Allow file removal when "git commit --all" is used.
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Aug 18, 2005, 10:49 UTC
- Message-ID
- <Pine.LNX.4.63.0508181248110.30218@wgmdd8.biozentrum.uni-wuerzburg.de>
- In-Reply-To
- <7v64u3k74m.fsf@assigned-by-dhcp.cox.net>
Hi,
On Thu, 18 Aug 2005, Junio C Hamano wrote:
Show 13 quoted lines
> After you deleted files from your working tree, automatic > git-update-cache used when the "--all" flag is given to "git > commit" barfs because it lacks the --remove flag. > > It can be argued that this is a feature; people should be > careful and something with a grave consequence like removing > files should be done manually, in which case the current > behaviour may be OK. > > The patch is for people who thinks the user who uses the "--all" > flag deserves the danger that comes with the convenience. > > Comments?
This is a sane default behaviour. Maybe introduce yet another flag "--no-remove", which says that removes should not be performed? But then, "--all" is mostly used by lazy people, who probably expect the removes to take place.
Ciao, Dscho