git reveals a bug in (some versions) BSD diff

Hi,

big was my surprise when my daily routine of "git pull" && "make test" failed. "git bisect" revealed that commit 8e832e: "String comparison of test is done with '=', not '=='." was the culprit.

But it isn't. The version of diff present on my iBook (OS 10.2.8) does not work properly in this case:

	(echo a; echo b | tr -d '\012') >frotz.2
	(echo a; echo c; echo b | tr -d '\012') >frotz.3
	diff -u frotz.2 frotz.3

yields

	--- a1  2005-08-12 14:24:19.000000000 +0200
	+++ a2  2005-08-12 14:24:27.000000000 +0200
	@@ -1,2 +1,3 @@
	 a
	+c
	 b

Note the missing "\ No newline at end of file". The same happens on sourceforge's compile farm's OS 10.1 server, but not on its OS 10.2 server.

How to go about that? Silently ignore the missing line in apply.c? Force users to update their diff to a sane version?

Ciao, Dscho