Re: [PATCH] Keep committer and committer dates

From: Jaroslav Kysela <perex@perex.cz>
Date: Jun 5, 2008, 14:11 UTC
Message-ID: <Pine.LNX.4.61.0806051600310.1798@tm8103-a.perex-int.cz>
In-Reply-To: <alpine.DEB.1.00.0806051452380.21190@racer>

On Thu, 5 Jun 2008, Johannes Schindelin wrote:

Show 9 quoted lines

> > On Thu, 5 Jun 2008, Johannes Schindelin wrote:
> > 
> > > It would make a wonderfully helpful tool less helpful.
> > 
> > I don't agree. Tool is tool. Every tool can be used in a wrong way. A 
> > notice to documentation that some of functionality should be used very 
> > carefully should be enough.
> 
> In that case, could you please test this patch?

Could you please test to open emergency door in airplane (at best when the airplain is in air) without any good reason? The emergency door is also a tool, but it should be used in really specific situation.

> -- snip --
> [PATCH] git wrapper: --try-this

Show 7 quoted lines

> > If I changed portion of unpublished tree, as maintainer I can combine 
> > any patches and it might make sense to keep at least my commit dates for 
> > my reference.
> 
> The problem is _NOT_ the unpublished tree, but that you, as a maintainer, 
> committed something, but said that somebody else did.  Possibly avoiding 
> blame, shifting it to others.

I meant I'm commiter for last patches. So I don't shift my blame to others. Also even if I'm not the commiter of patches and removing or touching totaly different area (like just README or some or other little changes) in repository, I don't see a reason to not to do so. Of course in 99.9% cases it's better to do it with new commit, because with git-reset you split trees and users will have to force pull and will probably cry. But in some cases might be worth just to remove / modify a patch hardly.

						Jaroslav

----- Jaroslav Kysela <perex@perex.cz> Linux Kernel Sound Maintainer ALSA Project, Red Hat, Inc.