Re: Cogito: cg-clone doesn't like packed tag objects

From: Linus Torvalds <torvalds@osdl.org>
Date: Sep 27, 2005, 17:56 UTC
Message-ID: <Pine.LNX.4.58.0509271020530.3308@g5.osdl.org>
In-Reply-To: <7v64sm30dh.fsf@assigned-by-dhcp.cox.net>

On Tue, 27 Sep 2005, Junio C Hamano wrote:

Show 7 quoted lines

> 
> This is a bit hard and needs some thinking to do cleanly,
> because what is in info/refs is what is sent from the publisher
> side over git-native protocol at the beginning of the handshake,
> and it is not easy to add that to git-native protocol cleanly
> and backward-compatibly (I think I know how without breaking
> existing clients, but it is not clean).

Argh.

"git-upload-pack" very much on purpose never sends partial object stores: it really doesn't want to send a tag-object for you to even _look_ at unless it also sends all the objects that you are missing that the tag refers to.

I'd really be much happier with the tag fetching being separate.

For example, making

	git fetch --tags <dest>

fetch all tags _and_ the objects that they depend on would seem a _lot_ more appropriate.

The thing is, tags really may be totally private. For example, it makes sense to fetch tags when you pull an official tree (ie my kernel tree, or your git tree), but it does NOT make sense for me to fetch tags (automatically or not) when I pull from a developers tree.

That's why git fetch doesn't get the tags by default. It's WRONG.

But we could certainly make it _easier_ to get tags when you want them. "git-ls-remote" already helps you, and

	git-ls-remote ... | cut -f2 | grep '^refs/tags/'

completes the picture. No protocol changes necessary, just some added magic to git-fetch.sh.

Actually, here's a simple and stupid patch.

Untested as usual, but hey, how hard can it be?

		Linus

----

diff --git a/git-fetch.sh b/git-fetch.sh
--- a/git-fetch.sh
+++ b/git-fetch.sh
@@ -5,6 +5,7 @@
 _x40='[0-9a-f][0-9a-f][0-9a-f][0-9a-f][0-9a-f]'
 _x40="$_x40$_x40$_x40$_x40$_x40$_x40$_x40$_x40"
 
+tags=
 append=
 force=
 update_head_ok=
@@ -17,6 +18,9 @@ do
 	-f|--f|--fo|--for|--forc|--force)
 		force=t
 		;;
+	--tags)
+		tags=t
+		;;
 	-u|--u|--up|--upd|--upda|--updat|--update|--update-|--update-h|\
 	--update-he|--update-hea|--update-head|--update-head-|\
 	--update-head-o|--update-head-ok)
@@ -151,7 +155,12 @@ case "$update_head_ok" in
 	;;
 esac
 
-for ref in $(get_remote_refs_for_fetch "$@")
+taglist=
+if [ "$tags" ]; then
+	taglist=$(git-ls-remote "$remote" | awk '/refs\/tags/ { print $2":"$2 }')
+fi
+
+for ref in $(get_remote_refs_for_fetch "$@" $taglist)
 do
     refs="$refs $ref"