Re: [PATCH] Verbose git-daemon logging
- From
Linus Torvalds <torvalds@osdl.org>
- Date
- Sep 22, 2005, 23:58 UTC
- Message-ID
- <Pine.LNX.4.58.0509221651000.2553@g5.osdl.org>
- In-Reply-To
- <7vd5n0lle8.fsf@assigned-by-dhcp.cox.net>
On Thu, 22 Sep 2005, Junio C Hamano wrote:
> > The tail part still looks odd here. Maybe something like this?
And if you actually want it to be more reliable, don't use fputs. That can still split lines, and even if it doesn't, it doesn't help.
> + buf[buflen++] = '\n'; > + buf[buflen] = '\0'; > + > + fputs(buf, stderr);
Why use "fputs()", when you migth as well do write()?
Also, it would probably be nice if you allow the use of syslog()..
Linus