Re: Make time-based commit filtering work with topological ordering

From: Linus Torvalds <torvalds@osdl.org>
Date: Sep 20, 2005, 22:50 UTC
Message-ID: <Pine.LNX.4.58.0509201543140.2553@g5.osdl.org>
In-Reply-To: <7vpsr31ii7.fsf@assigned-by-dhcp.cox.net>

On Tue, 20 Sep 2005, Junio C Hamano wrote:

>
> This seems to break t6001 merge-order with max-age test.

Yes.

Merge-order with ages doesn't make sense. I'd seriously suggest removing --merge-order entirely, but in the meantime I think you should remove anything that tests dates and merge-order.

Merge-order doesn't use the normal limit rules, but does its own home-brew limiting. It could do the date-limiting on its own, if it wanted to, but I doubt it would make sense.

Try the example I had without my patches:

        [torvalds@g5 git]$ git-rev-list $(git-rev-parse --since="8 days ago" HEAD) | wc
             80      80    3280
        [torvalds@g5 git]$ git-rev-list --topo-order $(git-rev-parse --since="8 days ago" HEAD) | wc
             10      10     410

and I bet the same thing was true for --merge-order. And that's just not _sensible_. It doesn't make sense that a time limiter would depend on the order, but the way it used to be done it always did so for very fundamental reasons.

So the old code was broken. Any test for it was broken too.

		Linus