Re: [PATCH] format-patch: fix skipping of blank-lines

From: Linus Torvalds <torvalds@osdl.org>
Date: Jul 9, 2005, 01:42 UTC
Message-ID: <Pine.LNX.4.58.0507081838560.17536@g5.osdl.org>
In-Reply-To: <7vu0j44xi4.fsf@assigned-by-dhcp.cox.net>

On Fri, 8 Jul 2005, Junio C Hamano wrote:

>
> If it is fed a commit with more than one leading blank lines,
> the sed scripts git-format-patch-script used looped forever.
> This patch fixes it.

How about using "git-stripspace"? That's what it's there for. It strips whitespace from the end of lines, from the beginning, and from the end. It also removes multiple consecutive whitespace lines from within the body of the message - which might turn some people off, but I use that same thing when I do my automated email commits, so if you don't strip those lines from the email, they _will_ get stripped at commit time, so..

"git-stripspace" also doesn't get confused by non-empty lines that have spaces in them, like your script seems to be (ie /^$/ won't match a line that has a space on it).

		Linus