git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: rev-parse, unknown arguments and extended sha1's

From
Linus Torvalds <torvalds@osdl.org>
Date
Jun 24, 2005, 16:43 UTC
Message-ID
<Pine.LNX.4.58.0506240941520.11175@ppc970.osdl.org>
In-Reply-To
<20050624161718.GA14909@pc117b.liacs.nl>
On Fri, 24 Jun 2005, Sven Verdoolaege wrote:
Show 8 quoted lines
>
> This is what I use:
> 
> rev2=`echo $rev | sed -e 's/[^0-9a-f]//'`
> rev3=`echo $rev2 | sed -e 's/........................................//'`
> if test "x$rev3" = "x" -a "x$rev" = "x$rev2"; then
> 	echo "valid SHA1"
> fi
Oooh. UGGHLEE.
This is one reason I don't do much shell.

Anyway, I think I'll make git-rev-parse have some option to "error out if the result is anything but a single revision number", since this is really the only reason for git-rev-parse in the first place: to make readable scripts.

		Linus
Previous: Sven VerdoolaegeNext: Linus Torvalds
Message 4 of 5 in “rev-parse, unknown arguments and extended sha1's”
  1. Sven VerdoolaegeJun 24, 2005
  2. Linus TorvaldsJun 24, 2005
  3. Sven VerdoolaegeJun 24, 2005
  4. Linus TorvaldsJun 24, 2005
  5. Linus TorvaldsJun 24, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.