Re: 7fb9de4a830dd8969bc17a219c509a76dd3c9aad

From: Linus Torvalds <torvalds@osdl.org>
Date: Jun 6, 2005, 16:01 UTC
Message-ID: <Pine.LNX.4.58.0506060858140.1876@ppc970.osdl.org>
In-Reply-To: <20050606153940.20039.qmail@blackcubes.dyndns.org>

On Mon, 6 Jun 2005 jon@blackcubes.dyndns.org wrote:

>
> [PATCH] Modify git-rev-list to linearise the commit history in merge order.

Much nicer. Will apply after testing, however, not this part:

Show 9 quoted lines

> @@ -110,6 +145,8 @@ static enum cmit_fmt get_commit_format(c
>  	if (!strcmp(arg, "=short"))
>  		return CMIT_FMT_SHORT;
>  	usage(rev_list_usage);	
> +
> +	return CMIT_FMT_DEFAULT;
>  }			
>  
>

If you're bothered by a compiler warning (that I don't see, wonder why?), please mark usage() and die() with "__attribute__ ((__noreturn__))". Make it depend on GCC, ie

	#ifdef __GCC__
	#define NO_RETURN __attribute__((__noreturn__))
	#else
	#define NO_RETURN
	#endif

and then do

	extern void die(const char *, ...) NO_RETURN;

or something like that.

Anyway, that's indepdendent of this patch, but just fyi.

		Linus