git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] ls-tree: remove trailing slashes properly.

From
Linus Torvalds <torvalds@osdl.org>
Date
May 31, 2005, 22:19 UTC
Message-ID
<Pine.LNX.4.58.0505311507010.1876@ppc970.osdl.org>
In-Reply-To
<7vvf4zvzfw.fsf@assigned-by-dhcp.cox.net>
On Tue, 31 May 2005, Junio C Hamano wrote:
>
> A typo prevented trailing slashes from being removed properly.
This is still wrong.
> This fixes the problem that "drivers/char" which is a tree was
> not shown when "drivers/char/" is given.

I sent an earlier email pointing out that removing trailing slashes is _incorrect_, because it means that "drivers/char/" will match the _file_ "drivers/char", which is wrong.

IOW, the trailing slash should not be removed, it's the _test_ that is wrong.

I just checked in a fix for this in diffcore-patchspec.c, I'd hope that ls-tree could get it right too. Removing trailing slashes is a bandaid that hides one bug by making it appear as a different bug.

		Linus
Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 12 in “Re: [PATCH] allow pathspec to end with a slash”
  1. Linus TorvaldsMay 31, 2005
  2. Junio C HamanoMay 31, 2005
  3. 1/2 diff: consolidate test helper script pieces.Junio C Hamano, May 31, 2005
  4. 2/2 diff: Fix trailing slash handling.Junio C Hamano, May 31, 2005
  5. ls-tree: remove trailing slashes properly.Junio C Hamano, May 31, 2005
  6. Linus TorvaldsMay 31, 2005
  7. Junio C HamanoMay 31, 2005
  8. ls-tree: handle trailing slashes in the pathspec properly.Junio C Hamano, May 31, 2005
  9. Linus TorvaldsMay 31, 2005
  10. ls-tree: handle trailing slashes in the pathspec properly.Junio C Hamano, Jun 1, 2005
  11. Linus TorvaldsJun 1, 2005
  12. Junio C HamanoMay 31, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.