Re: [PATCH] diff-raw format update take #2.
- From
Linus Torvalds <torvalds@osdl.org>
- Date
- May 24, 2005, 01:50 UTC
- Message-ID
- <Pine.LNX.4.58.0505231847260.2307@ppc970.osdl.org>
- In-Reply-To
- <211e617258d9d993810f3c88bace255e.IBX@taniwha.stupidest.org>
On Mon, 23 May 2005, Chris Wedgwood wrote:
> > diff doesn't do this, so i'm not sure it's useful:
Indeed.
A few weeks ago (for the previous round of "what should the diff format be" discussions) I looked at what "diffstat" does to figure out what the name should be, and it's quite disgusting.
The sad part is that if it wasn't for the date that GNU diff puts out, we'd be ok (since only GNU diff historically did unified diffs). Then we'd just know that the filename ends at the newline, and screw people who use newlines in filenames.
Now, we can fix this for git-diffs, and make sure that we don't make that mistake, but that just covers git users.
Linus