Re: cogito - how do I ???

From: Linus Torvalds <torvalds@osdl.org>
Date: May 23, 2005, 14:35 UTC
Message-ID: <Pine.LNX.4.58.0505230731430.2307@ppc970.osdl.org>
In-Reply-To: <20050523071919.GG23388@cip.informatik.uni-erlangen.de>

On Mon, 23 May 2005, Thomas Glanzmann wrote:

> 
> > 	git-rev-tree MERGE_HEAD ^HEAD | git-diff-tree -v -m -s --stdin
> 
> This doesn't work for me:

Yeah, I'm an idiot.

Show 6 quoted lines

> Bit this does:
> 
> (faui00u) [~/work/git/git] git-rev-tree 2cb45e95438c113871fbbea5b4f629f9463034e7 ^09d74b3b5ac634495e17b92b2b785fa996ffce97 | awk '{print $2'} | sed 's#:.*##' | git-diff-tree -v -m -s --stdin
> 
> was that a typo or is git-diff-tree supposed to handle the output of
> git-rev-tree as well and it is a bug?

It was me just forgetting about the time thing in rev-tree, forcing you to have a second phase there (I usually use just "cut -d' ' -f2" - the input _can_ have the ":n" flag thing that rev-tree outputs, and git-diff-tree will just ignore it).

I actually suspect that whole time thing was a mistake, it seemed sensible back when we didn't have any other way of ordering the changesets well, but it's really a bad ordering anyway to do it by time (ie add a "sort -rn" in there), and we can (and probably should) order rev-tree output with some topological sort based on the commit tree.

		Linus