Re: [PATCH 3/3] Diff overhaul, adding the other half of copy detection.

From: Linus Torvalds <torvalds@osdl.org>
Date: May 21, 2005, 17:25 UTC
Message-ID: <Pine.LNX.4.58.0505211016140.2206@ppc970.osdl.org>
In-Reply-To: <7vfywgkj90.fsf_-_@assigned-by-dhcp.cox.net>

On Sat, 21 May 2005, Junio C Hamano wrote:

Show 6 quoted lines

>
> This patch extends diff-cache and diff-files to report the
> unmodified files to diff-core as well when -C (copy detection)
> is in effect, so that the unmodified files can also be used as
> the source candidates.  The existing test t4003 has been
> extended to cover this case.

I love how I can just say "oh, keep in mind that we might want to.." and 24 hours later you did it.

Applied and pushed out, and I enjoyed seeing the output of

	git-whatchanged -C

and doing a "/^copy" that shows it figuring out (correctly) that git-resolve-script was based on git-pull-script. Very cool.

I'm also somewhat surprised by the fact that it even seems to be usable on the kernel tree:

	diff --git a/include/asm-um/archparam-i386.h b/include/asm-um/elf-i386.h
	similarity index 89%
	copy from include/asm-um/archparam-i386.h
	copy to include/asm-um/elf-i386.h
	--- a/include/asm-um/archparam-i386.h
	+++ b/include/asm-um/elf-i386.h
	...

cool.

			Linus