git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] show changed tree objects with recursive git-diff-tree

From
Linus Torvalds <torvalds@osdl.org>
Date
May 21, 2005, 03:34 UTC
Message-ID
<Pine.LNX.4.58.0505202025480.2206@ppc970.osdl.org>
In-Reply-To
<7vsm0hpbub.fsf@assigned-by-dhcp.cox.net>
On Fri, 20 May 2005, Junio C Hamano wrote:
>
> Although I do not have immediate objections to what it tries to
> do, I have to think about the intent of the patch and its
> ramifications.

I really think it should be a totally separate flag to enable showing the sub-trees if the tree-blobification wants this.

In fact, I can pretty much _guarantee_ that the patch as posted is the wrong thing to do: it will do horribly wrong things for things like

	git-whatchanged arch/i386/kernel/head.S

(but I haven't tried it - try it yourself. The correct output for the kernel archive is just a single commit, and a single blob change in that commit).

My bet is that the patch will end up showing every single changeset that touches anything under "arch/", since such _trees_ will be marked as interesting. Which is absolutely the wrong thing to do.

Nico, try it, maybe you'll prove me wrong.
		Linus
Previous: Junio C HamanoNext: Nicolas Pitre
Message 3 of 9 in “show changed tree objects with recursive git-diff-tree”
  1. show changed tree objects with recursive git-diff-treeNicolas Pitre, May 21, 2005
  2. Junio C HamanoMay 21, 2005
  3. Linus TorvaldsMay 21, 2005
  4. Nicolas PitreMay 23, 2005
  5. Junio C HamanoMay 25, 2005
  6. Nicolas PitreMay 25, 2005
  7. Junio C HamanoMay 25, 2005
  8. Linus TorvaldsMay 21, 2005
  9. Junio C HamanoMay 21, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.