Re: [PATCH] Add -r flag to show-diff for diff-cache/diff-tree like output.
- From
Linus Torvalds <torvalds@osdl.org>
- Date
- Apr 26, 2005, 22:40 UTC
- Message-ID
- <Pine.LNX.4.58.0504261534590.18901@ppc970.osdl.org>
- In-Reply-To
- <7vy8b5mawy.fsf_-_@assigned-by-dhcp.cox.net>
On Tue, 26 Apr 2005, Junio C Hamano wrote:
> > This adds a new option -r (rational) to show-diff command, to > produce diff-cache/diff-tree compatible output.
Why not just make this the default? Who really cares about show-diff? I see that "cg-merge" uses it, but does so with the "s" flag, just to see whether there are any changes at all.
So why not just make "rational" the standard format, and then make "diff-tree-helper" warn about unmerged ("U") files?
As far as I can tell, that is really what _everybody_ wants.
And calling "-r" "rational", when it means "recursive" for diff-tree and diff-cache doesn't sound rational to me. It _is_ rational to just silently accept it as "recursive", the same way diff-cache does.
Linus