Re: [PATH] fix segfault in fsck-cache

From: Andreas Gal <gal@uci.edu>
Date: Apr 24, 2005, 05:24 UTC
Message-ID: <Pine.LNX.4.58.0504232223570.8755@sam.ics.uci.edu>
In-Reply-To: <Pine.LNX.4.58.0504232202380.7195@sam.ics.uci.edu>

This isn't working right either, depending on your ZLIB version. Do not apply.

Andreas

On Sat, 23 Apr 2005, Andreas Gal wrote:

Show 26 quoted lines

> 
> I somehow got some corrupted object files in my repository that zlib 
> refuses to decompress. This patch makes sure we abort early before the 
> memcpy a few lines downtream segfaults (due to total_out == 0).
> 
> Andreas
> 
> Signed-off-by: Andreas Gal <gal@uci.edu>
> 
> --- 66308ede85c2dad6b184fb74a7215b06a173d8f7/sha1_file.c
> +++ sha1_file.c
> @@ -155,6 +155,8 @@
>  
>  	inflateInit(&stream);
>  	ret = inflate(&stream, 0);
> +	if (ret != Z_OK)
> +		return NULL;
>  	if (sscanf(buffer, "%10s %lu", type, size) != 2)
>  		return NULL;
>  
> 
> -
> To unsubscribe from this list: send the line "unsubscribe git" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>