Re: git pull on ia64 linux tree

From: Linus Torvalds <torvalds@osdl.org>
Date: Apr 22, 2005, 22:34 UTC
Message-ID: <Pine.LNX.4.58.0504221521260.2344@ppc970.osdl.org>
In-Reply-To: <200504222203.j3MM3fV17003@unix-os.sc.intel.com>

On Fri, 22 Apr 2005 tony.luck@intel.com wrote:

Show 6 quoted lines

> 
> "git log" seems to have problems interpreting the dates ... looking at the
> commit entries, the time is right ... but it appears that git log applies
> the timezone correction twice, so the changes I just applied at 14:46 PDT
> look like I made them at quarter to five tomorrow morning (+14 hours from
> when I did).

Looks like you are right.

The seconds are already in UTC format, so I think "git log" is wrong to pass the UTC seconds in to "date", and then tell date that it was done in the original timezone.

I think it would be nice to use the TZ data to show the thing in the timezone of the committer, though. Dunno how to do that, maybe something like

	TZ=$tz date -d "1970-01-01 + $sec sec"

or whatever. Sadly, it looks like "date" doesn't understand timezone syntax like that - looks like TZ has to be in the long machine-unreadable format like "US/Pacific" etc. Stupid (either TZ or me - maybe I just don't know what the right format is).

		Linus