git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] update-cache --refresh cache entry leak

From
Linus Torvalds <torvalds@osdl.org>
Date
Apr 17, 2005, 03:35 UTC
Message-ID
<Pine.LNX.4.58.0504162033250.7211@ppc970.osdl.org>
In-Reply-To
<7v8y3i5o8t.fsf@assigned-by-dhcp.cox.net>
On Sat, 16 Apr 2005, Junio C Hamano wrote:
>
> When update-cache --refresh replaces an existing cache entry
> with a new one, it forgets to free the original.

I've seen this patch now three times, and it's been wrong every single time. Maybe we should add a comment?

That active-cache entry you free()'d was not necessarily allocated with malloc(). Most cache-entries are just mmap'ed directly from the index file.

Leaking is ok. We cannot leak too much.
		Linus
Previous: Junio C HamanoNext: Junio C Hamano
Message 2 of 3 in “update-cache --refresh cache entry leak”
  1. update-cache --refresh cache entry leakJunio C Hamano, Apr 16, 2005
  2. Linus TorvaldsApr 17, 2005
  3. Junio C HamanoApr 17, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.