Re: [PATCH] Cogito chicken-and-egg problem
- From
Daniel Barkalow <barkalow@iabervon.org>
- Date
- Apr 26, 2005, 16:38 UTC
- Message-ID
- <Pine.LNX.4.21.0504261229220.30848-100000@iabervon.org>
- In-Reply-To
- <1114531570.19478.6.camel@dv>
On Tue, 26 Apr 2005, Pavel Roskin wrote:
Show 12 quoted lines
> Hello! > > My patch for Makefile was misapplied, so installed commit-id is still > needed for "make" to succeed. > > Shell commands are processed by make before being passed to the shell, > and $(...) is expanded by make before new PATH is set, as it is done in > the current Makefile. > > Also, the dependency on commit-id was dropped from my patch for some > reason. I believe it's still needed. Also, we need a dependency on > cat-file, which is used by commit-id internally.
commit-id doesn't really use cat-file; the way it calls gitXnormid.sh definitely suppresses that section. In fact, commit-id with no arguments is simply an easy-to-remember way of doing "cat .git/HEAD" using a much more complicated script. Earlier, I sent a patch to just do this, since it avoids the whole issue.
(Also, .git/HEAD is a dependancy, since you want to redo the version script if you commit; but if you don't have it, that's okay and just means you're building from a tarball, which is described completely by VERSION)
-Daniel *This .sig left intentionally blank*