Re: [3/5] Add http-pull

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Apr 22, 2005, 19:46 UTC
Message-ID: <Pine.LNX.4.21.0504221532120.30848-100000@iabervon.org>
In-Reply-To: <200504212205.j3LM5J005103@unix-os.sc.intel.com>

On Thu, 21 Apr 2005 tony.luck@intel.com wrote:

Show 19 quoted lines

> On Wed, 20 Apr 2005, Brad Roberts wrote:
> > How about fetching in the inverse order.  Ie, deepest parents up towards
> > current.  With that method the repository is always self consistent, even
> > if not yet current.
> 
> Daniel Barkalow replied:
> > You don't know the deepest parents to fetch until you've read everything
> > more recent, since the history you'd have to walk is the history you're
> > downloading.
> 
> You "just" need to defer adding tree/commit objects to the repository until
> after you have inserted all objects on which they depend.  That's what my
> "wget" based version does ... it's very crude, in that it loads all tree
> & commit objects into a temporary repository (.gittmp) ... since you can
> only use "cat-file" and "ls-tree" on things if they live in objects/xx/xxx..xxx
> The blobs can go directly into the real repo (but to be really safe you'd
> have to ensure that the whole blob had been pulled from the network before
> inserting it ... it's probably a good move to validate everything that you
> pull from the outside world too).

The problem with this general scheme is that it means that you have to start over if something goes wrong, rather than resuming from where you left off (and being able to use what you got until then). I think a better solution is to track what things you mean to have and what things you expect you could get from where.

As for validation, I now have my programs (which I haven't gotten a chance to send out recently) checking everything as it is downloaded to make sure it is complete (zlib likes it) and has the correct hash.

	-Daniel
*This .sig left intentionally blank*