Re: [PATCH] Get commits from remote repositories by HTTP

From: Daniel Barkalow <barkalow@iabervon.org>
Date: Apr 16, 2005, 22:33 UTC
Message-ID: <Pine.LNX.4.21.0504161827480.30848-100000@iabervon.org>
In-Reply-To: <12c511ca050416152452a4c620@mail.gmail.com>

On Sat, 16 Apr 2005, Tony Luck wrote:

> On 4/16/05, Daniel Barkalow <barkalow@iabervon.org> wrote:
> > +        buffer = read_sha1_file(sha1, type, &size);
> 
> You never free this buffer.

Ideally, this should all be rearranged to share the code with read-tree, and it should be fixed in common.

> It would also be nice if you saved "tree" objects in some temporary file
> and did not install them until after you had fetched all the blobs and
> trees that this tree references.  Then if your connection is interrupted
> you can just restart it.

It looks over everything relevant, even if it doesn't need to download anything, so it should work to continue if it stops in between.

	-Daniel
*This .sig left intentionally blank*