Re: [PATCH 4/5] convert: Inhibit contraction of foreign $Id$ during stats.

From: Henrik Grubbström <grubba@roxen.com>
Date: Apr 6, 2010, 11:53 UTC
Message-ID: <Pine.GSO.4.63.1004061324530.1164@shipon.roxen.com>
In-Reply-To: <7v634bosjg.fsf@alter.siamese.dyndns.org>

On Thu, 1 Apr 2010, Junio C Hamano wrote:

> "Henrik Grubbström (Grubba)"  <grubba@grubba.org> writes:
>
>> @@ -462,6 +463,20 @@ static int ident_to_git(const char *path, const char *src, size_t len,

[...]

>
> Somehow this feels to me that it is applying a band-aid to solve a problem
> that does not exist, only because the second patch in this series to keep
> the foreign one left expanded were not such a good change after all...

True, this was the patch that I was least satisfied with, since it only solved a special case (albeit the special case that I was interested in).

The general case is when the canonic (ie *_to_git) conversion filter for a file has changed after the file was committed.

-- Henrik Grubbström grubba@grubba.org Roxen Internet Software AB grubba@roxen.com