Re: [PATCH 0/2] add case insensitivity option to bash completion
- From
Alison Winters <alisonatwork@outlook.com>
- Date
- Nov 29, 2022, 15:56 UTC
- Message-ID
- <PRAP192MB1506B74F9BB25061419FA228DE129@PRAP192MB1506.EURP192.PROD.OUTLOOK.COM>
- In-Reply-To
- <xmqqedtm4h93.fsf@gitster.g>
On 2022-11-29 10:38, Junio C Hamano wrote: > I did not try to figure out the reason but the topic with its tests > seem to break in 'seen' the linux-cmake-ctest CI job. > > https://github.com/git/git/actions/runs/3570230611/jobs/6001013549 > > but the same test does not break under usual "make test".
I cannot speak for how the changes of the ab/cmake-nix-and-ci impact the aw/complete-case-insensitive branch, but the failure seems to be pointing to a test that I have since changed in the v2 patch, on the suggestion of Szeder Gabor. The variable is no longer exported and the script is no longer sourced a second time. I don't know if those v2 changes would change the results of this test, but they might be a starting point for the other people CC:ed here to consider.
Alison