Re: [PATCH] imap-send: add option to mark sent messages as read or unread

From: Aditya Garg <gargaditya08@live.com>
Date: Jul 23, 2025, 17:55 UTC
Message-ID: <PN3PR01MB9597E3E9F6356FC4DF651DA0B85FA@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>

Show 18 quoted lines

> On 23 Jul 2025, at 11:22 PM, Junio C Hamano <gitster@pobox.com> wrote:
> 
> Junio C Hamano <gitster@pobox.com> writes:
> 
>> Aditya Garg <gargaditya08@live.com> writes:
>>> +    if (mark_seen) {
>>> +        curl_easy_setopt(curl, CURLOPT_UPLOAD_FLAGS, CURLULFLAG_SEEN);
>>> +    } else {
>>> +        curl_easy_setopt(curl, CURLOPT_UPLOAD_FLAGS, 0L);
>>> +    }
>>> +
>> Why so many braces around single-statement blocks?
>> According to
>> https://github.com/curl/curl/blob/master/docs/libcurl/symbols-in-versions
>> CURLULFLAG_SEEN first appeared in 8.13.0; INSTALL says we require 7.61.0
>> or later, so this may be OK.
> 
> It might be obvious, but I meant "may not be OK" here.

I understand. It anyways isn't a very important feature.