git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] imap-send: improve error messages for missing configuration

From
Aditya Garg <gargaditya08@live.com>
Date
Jun 20, 2025, 05:03 UTC
Message-ID
<PN3PR01MB95979FD989FB98E5F1F27145B87CA@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
In-Reply-To
<xmqq7c178c07.fsf@gitster.g>
On 20 June 2025 6:28:32 am IST, Junio C Hamano <gitster@pobox.com> wrote:
Show 24 quoted lines
>"Jörg Thalheim" <joerg@thalheim.io> writes:
>
>> The error message 'no imap store specified' was confusing because
>> it referred to 'store' when the actual missing configuration was
>> 'imap.folder'. Similarly, the host error message provided no
>> guidance on how to fix the issue.
>>
>> Improve both error messages to:
>> - Clearly state what configuration is missing
>> - Provide hints showing the exact git config commands needed
>> - Include examples of typical values
>>
>> This helps users quickly understand and resolve configuration issues
>> when using git imap-send.
>>
>> Signed-off-by: Jörg Thalheim <joerg@thalheim.io>
>> ---
>>  imap-send.c | 8 ++++++--
>>  1 file changed, 6 insertions(+), 2 deletions(-)
>
>It is curious that you are sending usability improvement patches to
>imap-send, which I was recently told to be completely broken wrt the
>use of imap.folder.  Is the claim I heard that it is totally broken
>not true after all, I wonder?
I assume either the person has used the seen branch, or has not tested the program itself.
Previous: Junio C HamanoNext: Aditya Garg
Message 3 of 11 in “imap-send: improve error messages for missing configuration”
  1. imap-send: improve error messages for missing configurationJörg Thalheim, Jun 19, 2025
  2. Junio C HamanoJun 20, 2025
  3. Aditya GargJun 20, 2025
  4. Aditya GargJun 20, 2025
  5. 0/2 imap-send: improve error messages for missing configurationJoerg Thalheim, Jun 20, 2025
  6. 1/2 imap-send: fix confusing 'store' terminology in error messageJoerg Thalheim, Jun 20, 2025
  7. 2/2 imap-send: improve error messages with configuration hintsJoerg Thalheim, Jun 20, 2025
  8. Junio C HamanoJun 20, 2025
  9. 0/2 imap-send: improve error messages for missing configurationJoerg Thalheim, Jun 20, 2025
  10. 1/2 imap-send: fix confusing 'store' terminology in error messageJoerg Thalheim, Jun 20, 2025
  11. 2/2 imap-send: improve error messages with configuration hintsJoerg Thalheim, Jun 20, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.