Re: [PATCH v13 02/10] imap-send: add support for OAuth2.0 authentication
- From
Aditya Garg <gargaditya08@live.com>
- Date
- Jun 6, 2025, 17:12 UTC
- Message-ID
- <PN3PR01MB959793AA498C4FD81313B101B86EA@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM>
- In-Reply-To
- <xmqqbjr03ipu.fsf@gitster.g>
Show 18 quoted lines
> On 6 Jun 2025, at 10:34 PM, Junio C Hamano <gitster@pobox.com> wrote: > > Aditya Garg <gargaditya08@live.com> writes: > >> I was thinking the same but though the code would be more readable >> in case if repeats. > > Sorry but I do not understand this comment at all. Not repeating so > that you do not have to fix or update all the repetitions later when > the code needs to do something different is one of the basics in the > software engineering, and less repetitious code is also easier to > understnad in the art of software field. > > If you start from a 20-line block and repeat it 5 times to grow it > 100 lines of code, the eyes of readers will start coasting over > after a few repetitions, and you may be able to smuggle unwanted > lines unnoticed. Unless you are aiming for such technique to do > something malicious, don't go there.
OMG why would I be malicious (˃̣̣̥ᯅ˂̣̣̥) It's just a matter of my personal taste. Obviously your points are valid. And sorry for my ignorance, I am still a rookie dev.