Re: [PATCH v2 0/5] git crashes with a SIGBUS on sparc64 during pull
- From
- Koakuma <koachan@protonmail.com>
- Date
- Jan 20, 2025, 15:20 UTC
- Message-ID
- <OZMxBc6aAmluYw1_O-0ML1kM7cHNUEuFuhQwX-jurD482L-tjh65TOSWSq-hRzVXvQ2Bnz5SRqzWphewMPH_j-KKSdRtI-f_aNCeIkDLVSI=@protonmail.com>
- In-Reply-To
- <20250119131224.GA1541095@coredump.intra.peff.net>
Jeff King <peff@peff.net> wrote:
Show 20 quoted lines
> Here's a v2 which fixes the reading side, as well. I think this should > let you get through a full run of unpack-objects, but please confirm. :) > > This also includes Junio's put_be32() tweak to silence sparse. > > [1/5]: bswap.h: squelch potential sparse -Wcast-truncate warnings > [2/5]: packfile: factor out --pack_header argument parsing > [3/5]: parse_pack_header_option(): avoid unaligned memory writes > [4/5]: index-pack, unpack-objects: use get_be32() for reading pack header > [5/5]: index-pack, unpack-objects: use skip_prefix to avoid magic number > > builtin/index-pack.c | 30 ++++++++++++------------------ > builtin/unpack-objects.c | 31 ++++++++++++------------------- > compat/bswap.h | 24 ++++++++++++------------ > pack.h | 3 ++- > packfile.c | 20 ++++++++++++++++++++ > packfile.h | 6 ++++++ > 6 files changed, 64 insertions(+), 50 deletions(-) > > -Peff
Okay, just tested the patchset here. Both the testcase from upthread and actual pulls seem to work well now, without any crashes happening. Thanks a lot!