git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/5] git crashes with a SIGBUS on sparc64 during pull

From
KKoakuma <koachan@protonmail.com>
Date
Jan 20, 2025, 15:20 UTC
Message-ID
<OZMxBc6aAmluYw1_O-0ML1kM7cHNUEuFuhQwX-jurD482L-tjh65TOSWSq-hRzVXvQ2Bnz5SRqzWphewMPH_j-KKSdRtI-f_aNCeIkDLVSI=@protonmail.com>
In-Reply-To
<20250119131224.GA1541095@coredump.intra.peff.net>
Jeff King <peff@peff.net> wrote:
Show 20 quoted lines
> Here's a v2 which fixes the reading side, as well. I think this should
> let you get through a full run of unpack-objects, but please confirm. :)
> 
> This also includes Junio's put_be32() tweak to silence sparse.
> 
> [1/5]: bswap.h: squelch potential sparse -Wcast-truncate warnings
> [2/5]: packfile: factor out --pack_header argument parsing
> [3/5]: parse_pack_header_option(): avoid unaligned memory writes
> [4/5]: index-pack, unpack-objects: use get_be32() for reading pack header
> [5/5]: index-pack, unpack-objects: use skip_prefix to avoid magic number
> 
> builtin/index-pack.c | 30 ++++++++++++------------------
> builtin/unpack-objects.c | 31 ++++++++++++-------------------
> compat/bswap.h | 24 ++++++++++++------------
> pack.h | 3 ++-
> packfile.c | 20 ++++++++++++++++++++
> packfile.h | 6 ++++++
> 6 files changed, 64 insertions(+), 50 deletions(-)
> 
> -Peff

Okay, just tested the patchset here. Both the testcase from upthread and actual pulls seem to work well now, without any crashes happening. Thanks a lot!

Previous: Jeff KingNext: Junio C Hamano
Message 21 of 22 in “[BUG] git crashes with a SIGBUS on sparc64 during pull”
  1. KoakumaJan 17, 2025
  2. Jeff KingJan 17, 2025
  3. Jeff KingJan 17, 2025
  4. 1/3 packfile: factor out --pack_header argument parsingJeff King, Jan 17, 2025
  5. Junio C HamanoJan 17, 2025
  6. Jeff KingJan 18, 2025
  7. KoakumaJan 18, 2025
  8. 2/3 parse_pack_header_option(): avoid unaligned memory writesJeff King, Jan 17, 2025
  9. Junio C HamanoJan 18, 2025
  10. Jeff KingJan 18, 2025
  11. 3/3 index-pack, unpack-objects: use skip_prefix to avoid magic numberJeff King, Jan 17, 2025
  12. KoakumaJan 17, 2025
  13. Jeff KingJan 18, 2025
  14. KoakumaJan 18, 2025
  15. 0/5 git crashes with a SIGBUS on sparc64 during pullJeff King, Jan 19, 2025
  16. 1/5 bswap.h: squelch potential sparse -Wcast-truncate warningsJeff King, Jan 19, 2025
  17. 2/5 packfile: factor out --pack_header argument parsingJeff King, Jan 19, 2025
  18. 3/5 parse_pack_header_option(): avoid unaligned memory writesJeff King, Jan 19, 2025
  19. 4/5 index-pack, unpack-objects: use get_be32() for reading pack headerJeff King, Jan 19, 2025
  20. 5/5 index-pack, unpack-objects: use skip_prefix to avoid magic numberJeff King, Jan 19, 2025
  21. KoakumaJan 20, 2025
  22. Junio C HamanoJan 21, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.