Re: Bug: Since Git 2.13.2 git rebase autostash doesn't use fast-forward (poor performance)

From: neuling@dakosy.de <neuling@dakosy.de>
Date: Jun 28, 2017, 08:22 UTC
Message-ID: <OF99731898.CA1C41BB-ONC125814D.002E02EC-C125814D.002E0B32@dakosy.de>
In-Reply-To: <xmqqvanh324p.fsf@gitster.mtv.corp.google.com>

Could you see this as suggestion for performance improvement or should I send another e-mail for a new task?

Regards, Mattias

Junio C Hamano <jch2355@gmail.com> schrieb am 27.06.2017 17:02:14:

Show 11 quoted lines

> Von: Junio C Hamano <gitster@pobox.com>
> An: neuling@dakosy.de
> Kopie: git@vger.kernel.org
> Datum: 27.06.2017 17:02
> Betreff: Re: Bug: Since Git 2.13.2 git rebase autostash doesn't use 
> fast-forward (poor performance)
> Gesendet von: Junio C Hamano <jch2355@gmail.com>
> 
> neuling@dakosy.de writes:
> 
> > since the latest version 2.13.2 "git pull --rebase --autostash"

doesn't

Show 15 quoted lines

> > use a fast forward if possible. 
> 
> This may not be a bug but instead a fix made deliberately.
> 
> cf. http://public-inbox.org/git/
> CAAZatrCaoB7EXVrCvC9RKmO02G5xcp8GPBaJefHfv7zAXVpL3Q@mail.gmail.com/
> 
> A deciding excerpt from the thread was:
> 
> > Correctness must trump optimizations
> 
> Patches to further update and resurrect the optimization without
> breaking correctness of course are of course very much welcomed.
> 
> Thanks.