RE: Git clean enumerates ignored directories (since 2.27)

From: Jason Gore <jason.gore@microsoft.com>
Date: Apr 22, 2021, 17:18 UTC
Message-ID: <MN2PR00MB068886B8F36DFC645138DA0489469@MN2PR00MB0688.namprd00.prod.outlook.com>
In-Reply-To: <YHf+m7vOQumdJXwX@coredump.intra.peff.net>

Sorry to add noise to this thread but since the github issue was closed I wanted to make sure I'm not missing any updates here. Would any updates come through on this thread? Thanks!

-----Original Message-----
From: Jeff King <peff@peff.net> 
Sent: Thursday, April 15, 2021 1:52 AM
To: brian m. carlson <sandals@crustytoothpaste.net>
Cc: Jason Gore <Jason.Gore@microsoft.com>; git@vger.kernel.org; Elijah Newren <newren@gmail.com>
Subject: Re: Git clean enumerates ignored directories (since 2.27)

On Wed, Apr 14, 2021 at 10:56:14PM +0000, brian m. carlson wrote:

Show 23 quoted lines

> ----
> #!/bin/sh
> 
> git init test-repo
> cd test-repo
> longname="directory"
> touch "$longname.txt"
> last=400
> for x in $(seq 1 $last); do
>   mkdir "x$longname$x"
>   mv directory* "x$longname$x"
>   mv "x$longname$x" "$longname$x"
> done
> git clean -ffdxn -e directory$last
> ----
> 
> When it fails, it will complain that it wasn't able to open the 
> directory.  It still exits zero, however.
> 
> I haven't bisected this, so I don't know if those patches are related 
> to the problem or not.  I'm a little short on time today to 
> investigate further, but hopefully this can get someone on the right 
> path with a modified version and git bisect run if nothing else.

It bisects to 8d92fb2927 (dir: replace exponential algorithm with a linear one, 2020-04-01). I won't pretend to understand everything going on in that commit, though.

-Peff