git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v12 3/3] grep: fix an edge case concerning ascii patterns and UTF-8 data

From
Hamza Mahfooz <someguy@effective-light.com>
Date
Oct 12, 2021, 23:01 UTC
Message-ID
<GYZV0R.L35VU8UQBN4L2@effective-light.com>
In-Reply-To
<87a6jjlzz1.fsf@evledraar.gmail.com>

On Sat, Oct 9 2021 at 03:37:58 AM +0200, Ævar Arnfjörð Bjarmason <avarab@gmail.com> wrote:

> Are there cases where my "utf8_all_the_things" POC patch would have
> turned on PCRE2_UTF, but yours doesn't? IOW is there a 1=1 mapping 
> still
> between the encoding mode log/revision.c thinks it's in & PCRE2_UTF?

As far as I can tell, the only place where ignore_locale is mutated is in setup_revisions(), so there should be a 1=1 mapping.

Previous: Ævar Arnfjörð Bjarmason
Message 5 of 5 in “grep: refactor next_match() and match_one_pattern() for external use”
  1. 1/3 grep: refactor next_match() and match_one_pattern() for external useHamza Mahfooz, Oct 8, 2021
  2. 2/3 pretty: colorize pattern matches in commit messagesHamza Mahfooz, Oct 8, 2021
  3. 3/3 grep: fix an edge case concerning ascii patterns and UTF-8 dataHamza Mahfooz, Oct 8, 2021
  4. Ævar Arnfjörð BjarmasonOct 9, 2021
  5. Hamza MahfoozOct 12, 2021

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.