Re: [PATCH v2] Configure Git contribution guidelines for github.com

From: Lars Schneider <larsxschneider@gmail.com>
Date: Jun 14, 2017, 07:28 UTC
Message-ID: <FEFF27D2-1A56-4F37-8114-126613C144A0@gmail.com>
In-Reply-To: <20170613090427.igjz7erniblh3wie@sigill.intra.peff.net>

Show 12 quoted lines

> On 13 Jun 2017, at 11:04, Jeff King <peff@peff.net> wrote:
> 
> On Tue, Jun 13, 2017 at 10:18:07AM +0200, Lars Schneider wrote:
> 
>> changes since v1:
>> * mention submitGit
>> * link to mailing list address instead of mailing list archive
> 
> You might want to link to https://git-scm.com/community/, which has a
> section on the mailing list at the top. It gives the list address but
> also talks about the archive, that you can send to it without
> subscribing, etc.

Agreed. I removed the mailing list email address as this is not useful until you have subscribed to the list.

Show 19 quoted lines

> 
> The text itself looks good, but two minor grammar nits:
> 
>> diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
>> new file mode 100644
>> index 0000000000..fc397bb8fc
>> --- /dev/null
>> +++ b/.github/CONTRIBUTING.md
>> @@ -0,0 +1,19 @@
>> +## Contributing to Git
>> +
>> +Thanks for taking the time to contribute to Git! Please be advised, that the
>> +Git community does not use github.com for their contributions. Instead, we use
>> +a mailing list (git@vger.kernel.org) for code submissions, code
>> +reviews, and bug reports.
> 
> I think the comma after "advised" is unnecessary (you could also drop
> "that" to turn the first part into an introductory clause, but I think
> it reads better with as "Please be advised that").

Agreed!

Thank you, Lars