RE: [PATCH v5] convert: return early when not tracing

From: Haritha D <harithamma.d@ibm.com>
Date: Jul 31, 2024, 09:32 UTC
Message-ID: <F903ADA1-8F03-481E-9AC9-7ABFBE205D9D@ibm.com>
In-Reply-To: <xmqqle1i8eov.fsf@gitster.g>

Hey Junio,

You're right. I forgot to respond to that question. I used full name based on Jeff's suggestion. I will ensure it remains consistent. Thank you reminding me.

Best Regards Haritha

On 31/07/24, 8:12 AM, "Junio C Hamano" <gitster@pobox.com <mailto:gitster@pobox.com>> wrote:

"Haritha via GitGitGadget" <gitgitgadget@gmail.com <mailto:gitgitgadget@gmail.com>> writes:

Show 15 quoted lines

> From: D Harithamma <harithamma.d@ibm.com <mailto:harithamma.d@ibm.com>>
>
> When Git adds a file requiring encoding conversion and tracing of encoding
> conversion is not requested via the GIT_TRACE_WORKING_TREE_ENCODING
> environment variable, the `trace_encoding()` function still allocates &
> prepares "human readable" copies of the file contents before and after
> conversion to show in the trace. This results in a high memory footprint
> and increased runtime without providing any user-visible benefit.
>
> This fix introduces an early exit from the `trace_encoding()` function
> when tracing is not requested, preventing unnecessary memory allocation
> and processing.
>
> Signed-off-by: Harithamma D <harithamma.d@ibm.com <mailto:harithamma.d@ibm.com>>
> ---

It seems that you forgot to adjust to

https://lore.kernel.org/git/xmqqed7gyyyd.fsf@gitster.g/ <https://lore.kernel.org/git/xmqqed7gyyyd.fsf@gitster.g/>

where I asked you to be consistent in the authorship name and sign off.

For now, as I like to allow "git shortlog --author=..." to group contributions by a single author to a single bucket, I'll rewrite both to the same name as used in d254e650 (build: support z/OS (OS/390)., 2024-03-06), but will not merge it down to 'next' before I hear what your response is.

Thanks.