git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [GSoC PATCH v2 2/2] json-writer: describe the usage of jw_* functions

From
Lucas Seiki Oshiro <lucasseikioshiro@gmail.com>
Date
May 13, 2025, 22:22 UTC
Message-ID
<F862E606-C784-433C-BAB1-283C678E20D5@gmail.com>
In-Reply-To
<CAOLa=ZQooC0TsjGG109MY_njoTm5GjW-WNf7-L2W6BN8umRL2Q@mail.gmail.com>
> Overall this looks good, but I do have to wonder if it is needed given
> that your previous patch already has documentation for each function.

Agreed, it looks like too much information. This second patch was created after the review of v1, and to be honest, I think that this overview is more clear as it focus in the what we want (write a JSON) instead of documenting each function.

So, if I need to choose one of them, I'll choose this.
> But I'll leave that decision to you.
Ok, I'll keep the second!
> Thanks for working on this!
Thank you!
Previous: Karthik NayakNext: Patrick Steinhardt
Message 10 of 12 in “json-writer: describe the jw_* functions”
  1. 0/2 json-writer: describe the jw_* functionsLucas Seiki Oshiro, May 12, 2025
  2. 1/2 json-writer: add docstrings to jw_* functionsLucas Seiki Oshiro, May 12, 2025
  3. Patrick SteinhardtMay 12, 2025
  4. Lucas Seiki OshiroMay 13, 2025
  5. Patrick SteinhardtMay 14, 2025
  6. Karthik NayakMay 12, 2025
  7. 2/2 json-writer: describe the usage of jw_* functionsLucas Seiki Oshiro, May 12, 2025
  8. Patrick SteinhardtMay 12, 2025
  9. Karthik NayakMay 12, 2025
  10. Lucas Seiki OshiroMay 13, 2025
  11. Patrick SteinhardtMay 14, 2025
  12. Karthik NayakMay 12, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.