Re: [PATCH] userdiff: add support for Fountain documents

From: Zoë Blade <zoe@bytenoise.co.uk>
Date: Jul 21, 2015, 13:23 UTC
Message-ID: <F67D2953-FCA5-43F8-A370-13C77B14553B@bytenoise.co.uk>
In-Reply-To: <xmqqegk2y1dm.fsf@gitster.dls.corp.google.com>

On 20 Jul 2015, at 22:17, Junio C Hamano <gitster@pobox.com> wrote:

>> +PATTERNS("fountain", "^((\\.|(([Ii][Nn][Tt]|[Ee][Ss][Tt]|[Ee][Xx][Tt])?\\.?|[Ii]([Nn][Tt])?\\.?/[Ee]([Xx][Tt])?\\.?) ).+)$",
>> +	 "[^ \t-]+"),
> 
> Wouldn't IPATTERN() be a better choice here?

Good point, thank you!  Much better:

IPATTERN("fountain", "^((\\.|((int|est|ext)?\\.?|i(nt)?\\.?/e(xt)?\\.?) ).+)$", "[^ \t-]+"),

It looks like some of the others might benefit from being case insensitive too, but I'm not sure, and at any rate it would warrant a separate patch.

I'll send another revision next... :)

Thanks, Zoë.