Re: [PATCH] Support 64-bit indexes for pack files.

From: Geert Bosch <bosch@adacore.com>
Date: Feb 27, 2007, 20:25 UTC
Message-ID: <F4EA27AD-EF1C-4BF2-8D52-945E0AE51006@adacore.com>
In-Reply-To: <Pine.LNX.4.63.0702272102440.22628@wbgn013.biozentrum.uni-wuerzburg.de>

On Feb 27, 2007, at 15:05, Johannes Schindelin wrote:

Show 12 quoted lines

> On Tue, 27 Feb 2007, Geert Bosch wrote:
>
>> The object-count at the beginning of the pack is a little strange for
>> local on-disk pack files, as it is data that can easily be derived.
>
> The SHA1 is also easily derived. So think of it as a doubly secure  
> way to
> ensure integrity.
>
> Remember, there were some people unable to accept that SHA1  
> collisions are
> _unlikely_...

Ah, you include the count because you don't trust the SHA1 and now you can count that you got the right number of objects ;-)

It's just that I don't see a use for the count in a local on-disk pack. In these cases we'll always have an index. We can keep the current protocol for sending/receiving packs, no need to ever upgrade to v4 there.

   -Geert