Re: [PATCH 8/8] push: teach push to be quiet if local ref is strict subset of remote ref

From: Steffen Prohaska <prohaska@zib.de>
Date: Oct 28, 2007, 08:20 UTC
Message-ID: <F12160CA-1778-499F-A3D7-42711FB8B2CC@zib.de>
In-Reply-To: <7vfxzvwvde.fsf@gitster.siamese.dyndns.org>

On Oct 28, 2007, at 8:28 AM, Junio C Hamano wrote:

Show 15 quoted lines

> Steffen Prohaska <prohaska@zib.de> writes:
>
>> git push reports errors if a remote ref is not a strict subset
>> of a local ref. The push wouldn't be a fast-forward and is
>> therefore refused. This is in general a good idea.
>
>> This commit teaches git push to be quiet if the local is a strict
>> subset of the remote and no refspec is explicitly specified on
>> the command line. If the --verbose flag is used a "note:" is
>> printed for each ignored branch.
>
> What happens to the summary reporting after such a push?  Does
> it say "branch foo was not pushed because you did not touch it
> since you fetched and it is already stale with respect to the
> remote side which has updates since then"?

It says nothing, it's quiet, as promised in the commit message ;) That's the point of this patch.

But I see your point. Maybe it should say something like "ignored 2 branches, which are strict subsets of remote." "use --verbose for details." ?

> How does this interact with the "pretend we have fetched
> immediately after we pushed by updating the corresponding remote
> tracking branch" logic?

I doesn't change a remote tracking branch. I'll add a test confirming this.

	Steffen